fix(webapp): stop logging full batch item contents in batchTriggerV3 - #4404
Merged
Conversation
|
carderne
force-pushed
the
fix/batch-trigger-item-log-sec-405
branch
from
July 28, 2026 08:54
7f5f033 to
a978755
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (18)
WalkthroughRemoved a debug log in the batch trigger service that recorded the full 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
carderne
marked this pull request as ready for review
July 28, 2026 09:59
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ericallam
requested changes
Jul 29, 2026
The idempotency grouping step logged every batch item verbatim, including its payload and options (which can carry arbitrary customer metadata). Replace that with a summary of task identifiers and item counts, and add a unit test covering the summary shape.
carderne
force-pushed
the
fix/batch-trigger-item-log-sec-405
branch
from
July 29, 2026 16:37
7a8a5c7 to
89d0eaa
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
ericallam
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The idempotency grouping diagnostic now records task identifiers and item counts rather than full batch items. This keeps the log useful for troubleshooting without including payloads or options.
Performance notes
Should be better than baseline.